Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 9, 2025

PR-Codex overview

This PR focuses on enhancing the contract management system by updating the methods used to fetch published contracts. It introduces a new function to get the latest published contracts and modifies several components to utilize this new functionality.

Detailed summary

  • Added export const dynamic = "force-static"; to page.tsx files.
  • Replaced getPublishedContractsWithPublisherMapping with getLatestPublishedContractsWithPublisherMapping across multiple files.
  • Introduced getLatestPublishedContractsWithPublisherMapping function.
  • Updated contract fetching logic to ensure the latest version is retrieved.
  • Modified the fetchPublishedContractVersions function to include getSortedPublishedContractVersions.
  • Enhanced error handling and data retrieval methods in the contract components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 9, 2025

@vercel
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 3:35pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 9, 2025 3:35pm
login ⬜️ Skipped (Inspect) Feb 9, 2025 3:35pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 9, 2025 3:35pm
wallet-ui ⬜️ Skipped (Inspect) Feb 9, 2025 3:35pm

@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 15:05 Inactive
@MananTank MananTank marked this pull request as ready for review February 9, 2025 15:05
@MananTank MananTank requested review from a team as code owners February 9, 2025 15:05
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 9, 2025
@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (cad9c74) to head (bc42c2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6214   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cad9c74
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: bc42c2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 15:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 15:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 15:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 15:07 Inactive
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 3 s (+3.28% 🔺) 3.9 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 6.7 s (+5.36% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 343 ms (-36.41% 🔽) 455 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 74 ms (+28.49% 🔺) 84 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 518 ms (-42.71% 🔽) 904 ms

contractId: contractId,
});

const sortedVersions = allVersions.toSorted((a, b) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this toSorted was throwing an error for me locally. I had to temporarily set it to [...allVersions].sort() to get it working locally. Not sure if it's an issue.

@MananTank MananTank marked this pull request as draft February 9, 2025 15:23
@MananTank MananTank marked this pull request as ready for review February 9, 2025 15:24
@MananTank MananTank marked this pull request as draft February 9, 2025 15:24
@MananTank MananTank marked this pull request as ready for review February 9, 2025 15:27
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 9, 2025

Merge activity

…er few others (#6214)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the contract fetching logic in the `dashboard` application to improve the retrieval of the latest published contracts. It replaces older functions with new ones that specifically fetch the latest contract versions.

### Detailed summary
- Added `export const dynamic = "force-static";` to `page.tsx` files.
- Replaced `getPublishedContractsWithPublisherMapping` with `getLatestPublishedContractsWithPublisherMapping` in multiple files.
- Introduced `getLatestPublishedContractsWithPublisherMapping` function to fetch the latest contract version.
- Updated `fetchPublishedContractVersions` to use `getSortedPublishedContractVersions`.
- Created `fetchLatestPublishedContractVersion` for fetching the latest version details.
- Modified `ContractCard` to use `ClientOnly` for rendering the `ContractPublisher`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 15:33 Inactive
@graphite-app graphite-app bot merged commit bc42c2f into main Feb 9, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3368 branch February 9, 2025 15:36
@vercel vercel bot temporarily deployed to Production – wallet-ui February 9, 2025 15:36 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 9, 2025 15:36 Inactive
@vercel vercel bot temporarily deployed to Production – login February 9, 2025 15:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 9, 2025 15:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants